Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

NumberPrioIssue
2 - ?Medium

Links are resolved in the model service. This makes it impossible for customers to write their own linking logic, which many of them have done. Please make this a configurable feature and default to false.

DXA publishes rich text like this:

<p>Hello <a href="tcm:90-123">world</a></p>

It resolves this into:

<p>Hello <a href="/world">world</a></p>

Although this is great, DD4T has link resolvers in the application which expect xlink:href attributes. The rich text should therefore be resolved into this:

<p>Hello <a href="/world" xlink:href="tcm:90-123" xmlns:xlink="http://www.w3.org/1999/xlink">world</a></p>


NOTE: latest version allows you to chose whether or not to resolve links AND remove namespaces. SDL is still discussing internally whether to split these to settings into:

  1. Resolve links (true or false, if true adds href="URL" without a namespace)
  2. Remove XMLNS (true or false, if true removes all namespace declarations and all xlink:* attributes)



3 - ? TSI-3034Low

When you start the model service before the discovery and content services are started, it returns the following error (even after the other services have been started):

{
"timestamp": "2018-01-29T17:13:22.830+0000",
"status": 500,
"error": "Internal Server Error",
"exception": "com.google.gson.JsonSyntaxException",
"message": "com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 1 column 1194 path $.claimValues..DOCUMENT_ROOT",
"path": "/PageModel/tcm/2//dd4t.html"
}


This may not be high prio or even a real issue, as long as there is a dependency configured from the model service to the discovery service. (QS)

8 - TSI-3024HighThere should be no copies of the legacy DD4T libraries in the DXA codebase. This is confusing to the customers and does not have any real advantages. We need to align releases (and hopefully not release DD4T at all anymore, other than defect fixes).
9 - ?High

The model service resolves links in rich text as well as the LinkUrl property in the DXA model, into hyperlinks without an extension. I understand why, because it is clean and many customers want it that way. But there are customers who currently route only **.html to their DD4T page controller. For these customers, the links will not work.


Could you make this behavior configurable? E.g.:

dxa.defaults.converter-extensionless-urls=true|false

It can default to true, so the default behavior remains the same as in the CTP.


...